lkml.org 
[lkml]   [2019]   [Oct]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 2/4] i2c: at91: implement i2c bus recovery
Date


On 04.10.2019 23:39, Uwe Kleine-König wrote:
> External E-Mail
>
>
> On Fri, Oct 04, 2019 at 09:35:23AM +0000, Claudiu.Beznea@microchip.com wrote:
>> Hi Kamel,
>>
>> On 02.10.2019 17:46, Kamel Bouhara wrote:
>>> +static int at91_init_twi_recovery_info(struct platform_device *pdev,
>>> + struct at91_twi_dev *dev)
>>> +{
>>> + struct i2c_bus_recovery_info *rinfo = &dev->rinfo;
>>> +
>>> + dev->pinctrl = devm_pinctrl_get(&pdev->dev);
>>> + if (!dev->pinctrl || IS_ERR(dev->pinctrl)) {
>>
>> You may use IS_ERR_OR_NULL() here.
>
> Can devm_pinctrl_get return NULL? From a quick look, it cannot.

Looking quickly though it, yes, it seems it can't.

>
> rule of thumb: IS_ERR_OR_NULL is wrong as it is a sign of poor return
> value semantics.
>
> Best regards
> Uwe
>
\
 
 \ /
  Last update: 2019-10-07 12:19    [W:0.054 / U:6.520 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site