[lkml]   [2019]   [Oct]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH v2] mtd: onenand: prevent memory leak in onenand_scan
> In onenand_scan if scan_bbt fails the allocated buffers for oob_buf,
> verify_buf, and page_buf should be released.

Can a wording like the following be nicer for the change description?

Release the memory for the buffers “oob_buf”, “verify_buf” and “page_buf”
after a call of the function “scan_bbt” failed in the implementation
of the function “onenand_scan”.

> Fixes: 5988af231978 ("mtd: Flex-OneNAND support")

> ---
> Changes in v2:

> for the hint).

Did you take another review comment into account for this patch change log?

> ---

Please replace the delimiter at this place by a blank line in subsequent messages.

> drivers/mtd/nand/onenand/onenand_base.c | 8 +++++++-


 \ /
  Last update: 2019-10-05 16:06    [W:0.195 / U:0.432 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site