lkml.org 
[lkml]   [2019]   [Oct]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v7 3/5] mfd: ioc3: Add driver for SGI IOC3 chip
On Fri, 4 Oct 2019 15:44:53 +0100
Lee Jones <lee.jones@linaro.org> wrote:

> On Thu, 03 Oct 2019, Thomas Bogendoerfer wrote:
> > + if (mask & BIT(IOC3_IRQ_ETH_DOMAIN))
> > + /* if eth irq is enabled we need to check in eth irq regs */
>
> Nit: Comments should be expressive. Please expand all of the
> short-hand in this sentence. It would also be nicer if you started
> with an uppercase character.
>
> Same with all of the other comments in this file.

ok.

> Other than that, it looks like it's really coming together. Once the
> above is fixed, please re-sumbit with my:

Thanks.

David,

before re-posting with the english grammer pimp up, is there anything
I should improve for the network part ? If not, could I get a acked-by
from your side ?

Thomas.

--
SUSE Software Solutions Germany GmbH
HRB 247165 (AG München)
Geschäftsführer: Felix Imendörffer

\
 
 \ /
  Last update: 2019-10-04 19:25    [W:0.118 / U:0.084 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site