[lkml]   [2019]   [Oct]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH 0/4] HiSilicon hip08 uncore PMU events additions
Em Fri, Oct 04, 2019 at 03:59:44PM +0100, John Garry escreveu:
> On 04/10/2019 15:38, Arnaldo Carvalho de Melo wrote:
> > Em Fri, Oct 04, 2019 at 11:36:58AM -0300, Arnaldo Carvalho de Melo escreveu:
> > > Em Fri, Oct 04, 2019 at 03:30:07PM +0100, John Garry escreveu:
> > > > On 04/09/2019 16:54, John Garry wrote:
> > > > > This patchset adds some missing uncore PMU events for the hip08 arm64
> > > > > platform.

> > > > > The missing events were originally mentioned in
> > > > >, when upstreaming the JSONs initially.

> > > > > It also includes a fix for a DDRC eventname.

> > > > Could I get these JSON updates picked up please? Maybe they were missed
> > > > earlier. Let me know if I should re-post.

> > > Looking at them now.

> > It would be really good if somehow we managed to have someone from the
> > ARM community to check and provide a Reviewed-by for those, i.e. someone
> > else than the poster to look at it and check that its ok, would that be
> > possible?

> For this specific case, I'm not sure how much traction or value there would
> be since we're just adding some missing events for custom IP.

Someone else inside your organization? If nobody is available, then so
be it, let that be clear in the JSON file (see below) and then I
wouldn't be waiting for acks/reviewed-by messages for such cases.

> But I do agree that more review of JSONs from the community is required - as
> I brought up here regarding a recent addition:
> Can we enforce that at least and/or
> results is cc'ed on anything ARM specific as a start?

I think this should be the case, would you be willing to add a note to
that effect at the top of the JSON files?

And an extra note at tools/perf/pmu-events/README telling users to look
at the json files to figure out what Reviewed-by tags are required for
something to get merged? One extra Reviewed-by would be ok? Who would be
the reviewers for each arch? Would that be at the top of the JSON file?

- Arnaldo

 \ /
  Last update: 2019-10-04 17:19    [W:0.168 / U:0.808 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site