lkml.org 
[lkml]   [2019]   [Oct]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 07/11] vhost: convert vhost_umem_interval_tree to half closed intervals
    On Thu, Oct 03, 2019 at 01:18:54PM -0700, Davidlohr Bueso wrote:
    > @@ -1320,15 +1320,14 @@ static bool iotlb_access_ok(struct vhost_virtqueue *vq,
    > {
    > const struct vhost_umem_node *node;
    > struct vhost_umem *umem = vq->iotlb;
    > - u64 s = 0, size, orig_addr = addr, last = addr + len - 1;
    > + u64 s = 0, size, orig_addr = addr, last = addr + len;

    maybe "end" or "end_addr" instead of "last".

    > diff --git a/drivers/vhost/vhost.h b/drivers/vhost/vhost.h
    > index e9ed2722b633..bb36cb9ed5ec 100644
    > --- a/drivers/vhost/vhost.h
    > +++ b/drivers/vhost/vhost.h
    > @@ -53,13 +53,13 @@ struct vhost_log {
    > };
    >
    > #define START(node) ((node)->start)
    > -#define LAST(node) ((node)->last)
    > +#define END(node) ((node)->end)
    >
    > struct vhost_umem_node {
    > struct rb_node rb;
    > struct list_head link;
    > __u64 start;
    > - __u64 last;
    > + __u64 end;
    > __u64 size;
    > __u64 userspace_addr;
    > __u32 perm;

    Preferably also rename __subtree_last to __subtree_end

    Looks good to me otherwise.

    --
    Michel "Walken" Lespinasse
    A program is never fully debugged until the last user dies.

    \
     
     \ /
      Last update: 2019-10-04 14:10    [W:6.181 / U:1.344 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site