[lkml]   [2019]   [Oct]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH v6 2/2] leds: Add control of the voltage/current regulator to the LED core
Hi Jean-Jacques,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on j.anaszewski-leds/for-next]
[cannot apply to v5.4-rc1 next-20191004]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see]

base: for-next
config: sparc-allyesconfig (attached as .config)
compiler: sparc64-linux-gcc (GCC) 7.4.0
wget -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
GCC_VERSION=7.4.0 make.cross ARCH=sparc

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <>

All warnings (new ones prefixed by >>):

drivers/leds/led-core.c: In function 'try_turn_on_regulator_if_needed':
>> drivers/leds/led-core.c:65:15: warning: overflow in implicit constant conversion [-Woverflow]
atomic_and(~REG_R_ON, &led_cdev->regulator_state);
drivers/leds/led-core.c: In function 'led_set_brightness_nopm':
drivers/leds/led-core.c:353:27: warning: overflow in implicit constant conversion [-Woverflow]
old = atomic_fetch_and(~REG_U_ON,

vim +65 drivers/leds/led-core.c

55 static void try_turn_on_regulator_if_needed(struct led_classdev *led_cdev)
56 {
57 int old = atomic_cmpxchg(&led_cdev->regulator_state, REG_R_OFF_U_ON,
58 REG_R_ON_U_ON);
59 if (old == REG_R_OFF_U_ON) {
60 int rc = regulator_enable(led_cdev->regulator);
62 if (rc) {
63 dev_err(led_cdev->dev,
64 "Failed to enable the regulator (%d)\n", rc);
> 65 atomic_and(~REG_R_ON, &led_cdev->regulator_state);
66 }
67 }
68 }

0-DAY kernel test infrastructure Open Source Technology Center Intel Corporation
[unhandled content-type:application/gzip]
 \ /
  Last update: 2019-10-05 04:34    [W:0.191 / U:0.464 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site