lkml.org 
[lkml]   [2019]   [Oct]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] phy-mvebu-a3700-utmi: Use devm_platform_ioremap_resource() in mvebu_a3700_utmi_phy_probe()
From
Date

On 26/09/19 9:50 PM, Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Thu, 26 Sep 2019 18:15:23 +0200
>
> Simplify this function implementation by using a known wrapper function.
>
> This issue was detected by using the Coccinelle software.
>
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>

merged, thanks!

-Kishon

> ---
> drivers/phy/marvell/phy-mvebu-a3700-utmi.c | 9 +--------
> 1 file changed, 1 insertion(+), 8 deletions(-)
>
> diff --git a/drivers/phy/marvell/phy-mvebu-a3700-utmi.c b/drivers/phy/marvell/phy-mvebu-a3700-utmi.c
> index ded900b06f5a..23bc3bf5c4c0 100644
> --- a/drivers/phy/marvell/phy-mvebu-a3700-utmi.c
> +++ b/drivers/phy/marvell/phy-mvebu-a3700-utmi.c
> @@ -216,20 +216,13 @@ static int mvebu_a3700_utmi_phy_probe(struct platform_device *pdev)
> struct device *dev = &pdev->dev;
> struct mvebu_a3700_utmi *utmi;
> struct phy_provider *provider;
> - struct resource *res;
>
> utmi = devm_kzalloc(dev, sizeof(*utmi), GFP_KERNEL);
> if (!utmi)
> return -ENOMEM;
>
> /* Get UTMI memory region */
> - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - if (!res) {
> - dev_err(dev, "Missing UTMI PHY memory resource\n");
> - return -ENODEV;
> - }
> -
> - utmi->regs = devm_ioremap_resource(dev, res);
> + utmi->regs = devm_platform_ioremap_resource(pdev, 0);
> if (IS_ERR(utmi->regs))
> return PTR_ERR(utmi->regs);
>
> --
> 2.23.0
>

\
 
 \ /
  Last update: 2019-10-23 07:27    [W:0.055 / U:1.908 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site