Messages in this thread |  | | Date | Wed, 23 Oct 2019 15:02:28 -0500 | From | Rob Herring <> | Subject | Re: [PATCH 1/4] dt-bindings: arm: Initial MStar vendor prefixes and compatible strings |
| |
On Mon, Oct 14, 2019 at 03:15:56PM +0900, Daniel Palmer wrote: > This adds a prefix for MStar and thingy.jp and then defines compatible > strings for the first MStar based board. > > Signed-off-by: Daniel Palmer <daniel@0x0f.com> > --- > .../devicetree/bindings/arm/mstar.yaml | 22 +++++++++++++++++++ > .../devicetree/bindings/vendor-prefixes.yaml | 4 ++++ > MAINTAINERS | 6 +++++ > 3 files changed, 32 insertions(+) > create mode 100644 Documentation/devicetree/bindings/arm/mstar.yaml > > diff --git a/Documentation/devicetree/bindings/arm/mstar.yaml b/Documentation/devicetree/bindings/arm/mstar.yaml > new file mode 100644 > index 000000000000..0ea5b2b9387f > --- /dev/null > +++ b/Documentation/devicetree/bindings/arm/mstar.yaml > @@ -0,0 +1,22 @@ > +# SPDX-License-Identifier: (GPL-2.0+ OR X11)
(GPL-2.0-only OR BSD-2-Clause) is preferred. Any reason to differ?
> +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/arm/mstar.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: MStar platforms device tree bindings > + > +maintainers: > + - Daniel Palmer <daniel@thingy.jp> > + > +properties: > + $nodename: > + const: '/' > + compatible: > + oneOf: > +
Drop the blank line.
> + - description: thingy.jp BreadBee > + items: > + - const: thingyjp,breadbee > + - const: mstar,infinity > + - const: mstar,infinity3
infinity vs. infinity3? What's the difference? It's generally sufficient to just list a board compatible and a SoC compatible.
> diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefixes.yaml > index 967e78c5ec0a..1425468188da 100644 > --- a/Documentation/devicetree/bindings/vendor-prefixes.yaml > +++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml > @@ -617,6 +617,8 @@ patternProperties: > description: Microsemi Corporation > "^msi,.*": > description: Micro-Star International Co. Ltd. > + "^mstar,.*": > + description: MStar Semiconductor, Inc. > "^mti,.*": > description: Imagination Technologies Ltd. (formerly MIPS Technologies Inc.) > "^multi-inno,.*": > @@ -943,6 +945,8 @@ patternProperties: > description: Three Five Corp > "^thine,.*": > description: THine Electronics, Inc. > + "^thingyjp,.*": > + description: thingy.jp > "^ti,.*": > description: Texas Instruments > "^tianma,.*": > diff --git a/MAINTAINERS b/MAINTAINERS > index a69e6db80c79..8b7913c13f9a 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -1981,6 +1981,12 @@ L: linux-arm-kernel@lists.infradead.org (moderated for non-subscribers) > F: arch/arm/mach-pxa/mioa701.c > S: Maintained > > +ARM/MStar SoC support > +M: Daniel Palmer <daniel@thingy.jp> > +L: linux-arm-kernel@lists.infradead.org (moderated for non-subscribers) > +F: Documentation/devicetree/bindings/arm/mstar.yaml > +S: Maintained > + > ARM/NEC MOBILEPRO 900/c MACHINE SUPPORT > M: Michael Petchkovsky <mkpetch@internode.on.net> > S: Maintained > -- > 2.23.0 >
|  |