lkml.org 
[lkml]   [2019]   [Oct]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v1 4/4] net: dsa: add support for Atheros AR9331 build-in switch
On Thu, Oct 17, 2019 at 11:35:48AM -0700, Florian Fainelli wrote:
>
>
> On 10/13/2019 11:15 PM, Oleksij Rempel wrote:
> > Provide basic support for Atheros AR9331 build-in switch. So far it
> > works as port multiplexer without any hardware offloading support.
>
> I glanced through the functional parts of the code, and it looks pretty
> straight forward, since there is no offloading done so far, do you plan
> on adding bridge offload eventually if nothing more?

Currently not. There are following reasons:
- I do it for the Freifunk project. It is currently not clear, what
functionality has higher priority.
- there are not many ar9331 based devices with enough RAM to run any
thing modern. There is even less devices using more then one switch
port.
- IPv6 support is important for this project, but old Atheros switches have some
known issues with IPv6 packages in hardware bridge mode. So, this
functionality will need more testing.

> When you submit v2, I would suggest splitting the tagger code from the
> switch driver code, just to make them easier to review.

ok.

Regards,
Oleksij
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |

\
 
 \ /
  Last update: 2019-10-18 07:08    [W:0.115 / U:1.008 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site