lkml.org 
[lkml]   [2019]   [Oct]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/8] kcsan: Add Kernel Concurrency Sanitizer infrastructure
On Wed, Oct 16, 2019 at 09:34:05PM +0200, Marco Elver wrote:
> On Wed, 16 Oct 2019 at 20:44, Peter Zijlstra <peterz@infradead.org> wrote:
> > > + /*
> > > + * Disable interrupts & preemptions, to ignore races due to accesses in
> > > + * threads running on the same CPU.
> > > + */
> > > + local_irq_save(irq_flags);
> > > + preempt_disable();
> >
> > Is there a point to that preempt_disable() here?
>
> We want to avoid being preempted while the watchpoint is set up;
> otherwise, we would report data-races for CPU-local data, which is
> incorrect.

Disabling IRQs already very much disables preemption. There is
absolutely no point in doing preempt_disable() when the whole section
already runs with IRQs disabled.

\
 
 \ /
  Last update: 2019-10-17 09:49    [W:0.090 / U:2.460 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site