lkml.org 
[lkml]   [2019]   [Oct]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH V5 2/3] dt-bindings: Add Logic PD Type 28 display panel
Hi Adam,

Thank you for the patch.

On Wed, Oct 16, 2019 at 08:51:46AM -0500, Adam Ford wrote:
> This patch adds documentation of device tree bindings for the WVGA panel
> Logic PD Type 28 display.
>
> Signed-off-by: Adam Ford <aford173@gmail.com>
> ---
> V5: Replace GPIO_ACTIVE_HIGH with 0 to fix make dt_binding_check -k
> V4: Update per Rob H's suggestions and copy other panel yaml example from 5.4-rc1
> V3: Correct build errors from 'make dt_binding_check'
> V2: Use YAML instead of TXT for binding
>
> diff --git a/Documentation/devicetree/bindings/display/panel/logicpd,type28.yaml b/Documentation/devicetree/bindings/display/panel/logicpd,type28.yaml
> new file mode 100644
> index 000000000000..2834287b8d88
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/panel/logicpd,type28.yaml
> @@ -0,0 +1,42 @@
> +# SPDX-License-Identifier: GPL-2.0
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/display/panel/logicpd,type28.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Logic PD Type 28 4.3" WQVGA TFT LCD panel
> +
> +maintainers:
> + - Adam Ford <aford173@gmail.com>
> +
> +allOf:
> + - $ref: panel-common.yaml#
> +
> +properties:
> + compatible:
> + const: logicpd,type28
> +
> + power-supply: true
> + enable-gpios: true
> + backlight: true
> + port: true
> +
> +required:
> + - compatible

Should the port be required too ? Apart from that,

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + lcd0: display {
> + compatible = "logicpd,type28";
> + enable-gpios = <&gpio5 27 0>;
> + backlight = <&backlight>;
> + port {
> + lcd_in: endpoint {
> + remote-endpoint = <&dpi_out>;
> + };
> + };
> + };
> +
> +...

--
Regards,

Laurent Pinchart

\
 
 \ /
  Last update: 2019-10-16 16:40    [W:0.151 / U:0.216 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site