lkml.org 
[lkml]   [2019]   [Oct]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] [V2] PCI: sysfs: remove pci_bridge_groups and pcie_dev_groups
On Wed, Oct 16, 2019 at 09:03:24AM +0100, Ben Dooks (Codethink) wrote:
> From: Ben Dooks <ben.dooks@codethink.co.uk>
>
> The pci_bridge_groups and pcie_dev_groups objects are
> not exported and not used at-all, so remove them to
> fix the following warnings from sparse:
>
> drivers/pci/pci-sysfs.c:1546:30: warning: symbol 'pci_bridge_groups' was not declared. Should it be static?
> drivers/pci/pci-sysfs.c:1555:30: warning: symbol 'pcie_dev_groups' was not declared. Should it be static?
>
> Also remove the unused pci_bridge_group and pcie_dev_group
> as they are not used any more.
>
> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>

Applied to pci/misc for v5.5, thanks a lot, Ben!

> ---
> Cc: Bjorn Helgaas <bhelgaas@google.com>
> Cc: linux-pci@vger.kernel.org
> Cc: linux-kernel@vger.kernel.org
>
> fixup - more unused pci bits
> ---
> drivers/pci/pci-sysfs.c | 18 ------------------
> 1 file changed, 18 deletions(-)
>
> diff --git a/drivers/pci/pci-sysfs.c b/drivers/pci/pci-sysfs.c
> index 793412954529..eaffb477c5bf 100644
> --- a/drivers/pci/pci-sysfs.c
> +++ b/drivers/pci/pci-sysfs.c
> @@ -1539,24 +1539,6 @@ const struct attribute_group *pci_dev_groups[] = {
> NULL,
> };
>
> -static const struct attribute_group pci_bridge_group = {
> - .attrs = pci_bridge_attrs,
> -};
> -
> -const struct attribute_group *pci_bridge_groups[] = {
> - &pci_bridge_group,
> - NULL,
> -};
> -
> -static const struct attribute_group pcie_dev_group = {
> - .attrs = pcie_dev_attrs,
> -};
> -
> -const struct attribute_group *pcie_dev_groups[] = {
> - &pcie_dev_group,
> - NULL,
> -};
> -
> static const struct attribute_group pci_dev_hp_attr_group = {
> .attrs = pci_dev_hp_attrs,
> .is_visible = pci_dev_hp_attrs_are_visible,
> --
> 2.23.0
>

\
 
 \ /
  Last update: 2019-10-17 00:18    [W:0.053 / U:5.980 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site