lkml.org 
[lkml]   [2019]   [Oct]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 2/2] net: lpc_eth: parse phy nodes from device tree
From
From: Alexandre Belloni <alexandre.belloni@bootlin.com>
Date: Thu, 10 Oct 2019 22:45:30 +0200

> When connected to a micrel phy, phy_find_first doesn't work properly
> because the first phy found is on address 0, the broadcast address but, the
> first thing the phy driver is doing is disabling this broadcast address.
> The phy is then available only on address 1 but the mdio driver doesn't
> know about it.
>
> Instead, register the mdio bus using of_mdiobus_register and try to find
> the phy description in device tree before falling back to phy_find_first.
>
> This ultimately also allows to describe the interrupt the phy is connected
> to.
>
> Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>

I asked you to address Andrew's feedback.

You can't let this sit for days like that.

Therefore, I'm dropping your patches.

\
 
 \ /
  Last update: 2019-10-16 20:24    [W:0.069 / U:1.984 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site