[lkml]   [2019]   [Oct]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH 2/5] KPC2000: kpc2000_spi.c: Fix style issues (missing blank line)

A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?
A: Top-posting.
Q: What is the most annoying thing in e-mail?

A: No.
Q: Should I include quotations after my reply?

On Fri, Oct 11, 2019 at 02:02:32AM -0700, Chandra Annamaneni wrote:
> The first set of patches were in a single commit. I started from scratch
> and built these patches from 5 different commits. Don't know if the first
> set of patches are relevant anymore.

They are not relevant to being applied, but this patch series has
changed based on the comments you received from the previous patch(s).
So it is relevant to how you got to this set of patches.

This makes it easier for reviewers to understand what changed and what
they need to focus on, or ignore, in your new set of patches. This
isn't for you, it is for the people you are sending these patches to.


greg k-h

 \ /
  Last update: 2019-10-11 11:12    [W:0.088 / U:1.652 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site