lkml.org 
[lkml]   [2019]   [Oct]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH 1/2] net: fec_main: Use platform_get_irq_byname_optional() to avoid error message
Date
From: Anson Huang <Anson.Huang@nxp.com> Sent: Wednesday, October 9, 2019 6:16 PM
> Failed to get irq using name is NOT fatal as driver will use index to get irq
> instead, use platform_get_irq_byname_optional() instead of
> platform_get_irq_byname() to avoid below error message during
> probe:
>
> [ 0.819312] fec 30be0000.ethernet: IRQ int0 not found
> [ 0.824433] fec 30be0000.ethernet: IRQ int1 not found
> [ 0.829539] fec 30be0000.ethernet: IRQ int2 not found
>
> Fixes: 7723f4c5ecdb ("driver core: platform: Add an error message to
> platform_get_irq*()")
> Signed-off-by: Anson Huang <Anson.Huang@nxp.com>

Acked-by: Fugang Duan <fugang.duan@nxp.com>

> ---
> drivers/net/ethernet/freescale/fec_main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/freescale/fec_main.c
> b/drivers/net/ethernet/freescale/fec_main.c
> index d4d4c72..22c01b2 100644
> --- a/drivers/net/ethernet/freescale/fec_main.c
> +++ b/drivers/net/ethernet/freescale/fec_main.c
> @@ -3558,7 +3558,7 @@ fec_probe(struct platform_device *pdev)
>
> for (i = 0; i < irq_cnt; i++) {
> snprintf(irq_name, sizeof(irq_name), "int%d", i);
> - irq = platform_get_irq_byname(pdev, irq_name);
> + irq = platform_get_irq_byname_optional(pdev, irq_name);
> if (irq < 0)
> irq = platform_get_irq(pdev, i);
> if (irq < 0) {
> --
> 2.7.4

\
 
 \ /
  Last update: 2019-10-10 08:56    [W:0.127 / U:0.452 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site