lkml.org 
[lkml]   [2019]   [Oct]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH 1/2] net: fec_main: Use platform_get_irq_byname_optional() to avoid error message
Date
Hi, Jakub

> On Wed, 9 Oct 2019 18:15:47 +0800, Anson Huang wrote:
> > Failed to get irq using name is NOT fatal as driver will use index to
> > get irq instead, use platform_get_irq_byname_optional() instead of
> > platform_get_irq_byname() to avoid below error message during
> > probe:
> >
> > [ 0.819312] fec 30be0000.ethernet: IRQ int0 not found
> > [ 0.824433] fec 30be0000.ethernet: IRQ int1 not found
> > [ 0.829539] fec 30be0000.ethernet: IRQ int2 not found
> >
> > Fixes: 7723f4c5ecdb ("driver core: platform: Add an error message to
> > platform_get_irq*()")
> > Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
>
> Hi Anson,
>
> looks like there may be some dependency which haven't landed in the
> networking tree yet? Because this doesn't build:
>
> drivers/net/ethernet/freescale/fec_main.c: In function ‘fec_probe’:
> drivers/net/ethernet/freescale/fec_main.c:3561:9: error: implicit declaration
> of function ‘platform_get_irq_byname_optional’; did you mean
> ‘platform_get_irq_optional’? [-Werror=implicit-function-declaration]
> 3561 | irq = platform_get_irq_byname_optional(pdev, irq_name);
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> | platform_get_irq_optional
> cc1: some warnings being treated as errors
>
> Could you please repost once that's resolved? Please add Andy's and
> Stephen's acks when reposting.
>
> Thank you!

Sorry, I did this patch set based on linux-next tree, the below patch is landing
on Linux-next tree on Oct 5th, so maybe network tree is NOT sync with Linux-next tree?
I saw many other similar patches are already landing on Linux-next tree also, so what
do you suggest I should do? Or can you sync the network tree with Linux-next tree first? I do
NOT know the rule/schedule of network tree update to Linux-next.

commit f1da567f1dc1b55d178b8f2d0cfe8353858aac19
Author: Hans de Goede <hdegoede@redhat.com>
Date: Sat Oct 5 23:04:47 2019 +0200

driver core: platform: Add platform_get_irq_byname_optional()

thanks,
Anson

\
 
 \ /
  Last update: 2019-10-11 02:05    [W:0.187 / U:0.096 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site