Messages in this thread |  | | From | Arnd Bergmann <> | Date | Tue, 1 Oct 2019 20:57:49 +0200 | Subject | Re: [PATCH] ARM: xen: unexport HYPERVISOR_platform_op function |
| |
On Tue, Oct 1, 2019 at 7:38 PM Stefano Stabellini <sstabellini@kernel.org> wrote:
> Thank you for the patch. HYPERVISOR_platform_op() is an inline function, > the underlying function that should be exported is > HYPERVISOR_platform_op_raw. So, instead of removing > HYPERVISOR_platform_op, we should change it to > HYPERVISOR_platform_op_raw.
Ok, that makes sense.
> For convenience, and for testing I cooked up a patch. Arnd, if you are > happy with it (in the sense that it solves your problem) we'll check it > in the xentip tree, unless you would like to get it in your tree? >
Please merge it through your tree.
> @@ -437,7 +437,7 @@ EXPORT_SYMBOL_GPL(HYPERVISOR_memory_op); > EXPORT_SYMBOL_GPL(HYPERVISOR_physdev_op); > EXPORT_SYMBOL_GPL(HYPERVISOR_vcpu_op); > EXPORT_SYMBOL_GPL(HYPERVISOR_tmem_op); > -EXPORT_SYMBOL_GPL(HYPERVISOR_platform_op); > +EXPORT_SYMBOL_GPL(HYPERVISOR_platform_op_raw); > EXPORT_SYMBOL_GPL(HYPERVISOR_multicall); > EXPORT_SYMBOL_GPL(HYPERVISOR_vm_assist); > EXPORT_SYMBOL_GPL(HYPERVISOR_dm_op);
Note that there are obviously no callers from any loadable modules in the kernel, all users are in built-in code at the moment. As an API definition it still makes sense though.
Arnd
|  |