lkml.org 
[lkml]   [2019]   [Jan]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: Bug report: unaligned access with ext4 encryption
Date
Eric Biggers <ebiggers@kernel.org> wrote:

> Hi Aaro, thanks for the bug report! I think you're on the right track; it makes
> much more sense to have the keyrings subsystem store the payload with better
> alignment, than to work around the 2-byte alignment in fscrypt.
>
> But how about '__aligned(__alignof__(u64))' instead? 4 bytes may not be enough.
>
> David, what do you think?

Does that even work?

Might be better to just insert 6 bytes of padding with a comment, but yes I
agree that it's probably better to align it to at least machine word size.

David

\
 
 \ /
  Last update: 2019-01-04 18:29    [W:0.331 / U:0.024 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site