lkml.org 
[lkml]   [2019]   [Jan]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v8 5/7] tpm: move tpm_chip definition to include/linux/tpm.h
From
Date
On 1/29/2019 9:34 PM, Jarkko Sakkinen wrote:
> On Thu, Jan 24, 2019 at 04:49:08PM +0100, Roberto Sassu wrote:
>> -enum tpm_const {
>> - TPM_MINOR = 224, /* officially assigned */
>> - TPM_BUFSIZE = 4096,
>> - TPM_NUM_DEVICES = 65536,
>> - TPM_RETRY = 50, /* 5 seconds */
>> - TPM_NUM_EVENT_LOG_FILES = 3,
>> -};
>
> Here using enum has been a bad idea in the first place, as they don't
> relate in any meaningful way.
>
> Replace the definition with the following in drivers/char/tpm/tpm.h:
>
> #define TPM_MINOR 224 /* misc backwards compatibility */
> #define TPM_BUFSIZE 4096
> #define TPM_NUM_DEVICES 65536
> #define TPM_RETRY 5 /* seconds */

Is 5 correct? TPM_RETRY was 50 before.

Roberto


> And only add this to include/linux/tpm.h:
>
> #define TPM_NUM_EVENT_LOG_FILES 3
>
> Otherwise, this looks good.
>
> /Jarkko
>

--
HUAWEI TECHNOLOGIES Duesseldorf GmbH, HRB 56063
Managing Director: Bo PENG, Jian LI, Yanli SHI

\
 
 \ /
  Last update: 2019-01-31 08:57    [W:0.107 / U:7.216 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site