lkml.org 
[lkml]   [2019]   [Jan]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2] arm: dts: gta04: add gps support
On Wed, 30 Jan 2019 10:04:34 +0100
Johan Hovold <johan@kernel.org> wrote:

> On Tue, Jan 29, 2019 at 08:38:43AM +0100, Andreas Kemnade wrote:
> > The GTA04 has a w2sg0004 or w2sg0084 gps chip. Not detectable
> > which one is mounted so use the compatibility entry for w2sg0004
> > for all which will work for both.
> >
> > Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
> > ---
> > Changes in v2:
> > - some s/gps/gnss/
> > - not added vcc-supply because the regulator is not modelled
> > in dts at all
>
> I strongly suggest not sending revised patches before people have a
> chance to comment on your previous version and resolve any issues that
> may have been raised.

for technical check there was already some small team review ahead,
so I expect only formality issues and not something complicated and
was not mentally prepared for more discussion.

At that point I had the impression that I am not allowed to have
such driverless things into dtb, so I had the impression that I have
to follow two conflicting rules at the same time.
That leads to the impression that I worked a long way into a dead end
which made me quite angry so I was not as contructive as I should be.

Regards,
Andreas
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2019-01-31 17:42    [W:0.069 / U:3.412 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site