lkml.org 
[lkml]   [2019]   [Jan]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 1/2] mmc: cqhci: replace NUM_SLOTS with cq_host->num_slots
From
Date
On 14/01/19 9:17 PM, Alamy Liu wrote:
> Prevent to use fixed value (NUM_SLOTS) after it had been determined
> and saved in a variable (cq_host->num_slots).

num_slots is always 32 (i.e. NUM_SLOTS) so why not go the other way and get
rid of num_slots and just use NUM_SLOTS?

>
> Signed-off-by: Alamy Liu <alamy.liu@gmail.com>
> ---
> drivers/mmc/host/cqhci.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/cqhci.c b/drivers/mmc/host/cqhci.c
> index 159270e947..26d63594b7 100644
> --- a/drivers/mmc/host/cqhci.c
> +++ b/drivers/mmc/host/cqhci.c
> @@ -699,7 +699,7 @@ static void cqhci_error_irq(struct mmc_host *mmc, u32 status, int cmd_error,
> * The only way to guarantee forward progress is to mark at
> * least one task in error, so if none is indicated, pick one.
> */
> - for (tag = 0; tag < NUM_SLOTS; tag++) {
> + for (tag = 0; tag < cq_host->num_slots; tag++) {
> slot = &cq_host->slot[tag];
> if (!slot->mrq)
> continue;
>

\
 
 \ /
  Last update: 2019-01-31 10:35    [W:0.128 / U:0.108 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site