lkml.org 
[lkml]   [2019]   [Jan]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: linux-next: Fixes tags needs some work in the akpm-current tree
On Thu, Jan 31, 2019 at 02:57:34PM -0800, Andrew Morton wrote:
> On Thu, 31 Jan 2019 22:51:52 +0000 Liviu Dudau <liviu@dudau.co.uk> wrote:
>
> > On Wed, Jan 30, 2019 at 08:51:42PM -0500, Qian Cai wrote:
> > >
> > >
> > > On 1/30/19 7:05 PM, Stephen Rothwell wrote:
> > > > In commit
> > > >
> > > > 6e9ed490d190 ("mm/page_owner: fix for deferred struct page init")
> > > >
> > > > Fixes tag
> > > >
> > > > Fixes: fe53ca54270 ("mm: use early_pfn_to_nid in page_ext_init")
> > > >
> > > > has these problem(s):
> > > >
> > > > - SHA1 should be at least 12 digits long
> > > > Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
> > > > or later) just making sure it is not set (or set to "auto").
> > > >
> > >
> > > I think it is better to replace with this version instead,
> > >
> > > https://lore.kernel.org/lkml/20190115202812.75820-1-cai@lca.pw/
> >
> >
> > That patch does not look related, afaict.
>
> Confused.
>
> https://lore.kernel.org/lkml/20190115202812.75820-1-cai@lca.pw/
> and
> https://lore.kernel.org/lkml/20181220203156.43441-1-cai@lca.pw/T/#u
>
> are very much related?

My bad, I've read the top of the message that was talking about my commit splitting the
Fixes: commit title into multiple lines and assumed that was the only issue reported.


>
> > Andrew, do you want me to re-send the patch with a fixed commit log, or are you OK to
> > do some inline editing?
>
> Resend what, exactly?

Content of commit 86c7502b25ed so that the title of the commit it fixes does not spill
over into the next line.

Best regards,
Liviu


--
________________________________________________________
________| |_______
\ | With enough courage, you can do without a reputation | /
\ | -- Rhett Butler | /
/ |________________________________________________________| \
/__________) (_________\

\
 
 \ /
  Last update: 2019-02-01 01:19    [W:0.063 / U:11.664 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site