lkml.org 
[lkml]   [2019]   [Jan]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v2 10/14] arm64: dts: qcom: qcs404: Add OPP table
From
Date
On 1/30/19 05:41, Vinod Koul wrote:
> On 28-01-19, 19:32, Jorge Ramirez-Ortiz wrote:
>> Add a CPU OPP table to qcs404
>>
>> Co-developed-by: Niklas Cassel <niklas.cassel@linaro.org>
>> Signed-off-by: Niklas Cassel <niklas.cassel@linaro.org>
>> Signed-off-by: Jorge Ramirez-Ortiz <jorge.ramirez-ortiz@linaro.org>
>> ---
>> arch/arm64/boot/dts/qcom/qcs404.dtsi | 15 +++++++++++++++
>> 1 file changed, 15 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/qcs404.dtsi b/arch/arm64/boot/dts/qcom/qcs404.dtsi
>> index 9b5c165..4594fea7 100644
>> --- a/arch/arm64/boot/dts/qcom/qcs404.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/qcs404.dtsi
>> @@ -62,6 +62,21 @@
>> };
>> };
>>
>> + cpu_opp_table: cpu_opp_table {
>
> This should be:
> cpu_opp_table: cpu-opp-table

yes. um I thought I fixed this ..sorry about it.

>
> IIRC node names are not supposed to have _ and tags not supposed to have
> -, please compile with W=12 to trigger these warnings :)
>
>> + compatible = "operating-points-v2";
>> + opp-shared;
>> +
>> + opp-1094400000 {
>> + opp-hz = /bits/ 64 <1094400000>;
>> + };
>> + opp-1248000000 {
>> + opp-hz = /bits/ 64 <1248000000>;
>> + };

also need to remove the frequency below. I might have sent the wrong
version of this file

>> + opp-1401600000 {
>> + opp-hz = /bits/ 64 <1401600000>;
>> + };
>> + };
>> +
>> firmware {
>> scm: scm {
>> compatible = "qcom,scm-qcs404", "qcom,scm";
>> --
>> 2.7.4
>

\
 
 \ /
  Last update: 2019-01-30 10:09    [W:0.045 / U:9.012 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site