lkml.org 
[lkml]   [2019]   [Jan]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] selftests: net: fix "from" match test in fib_rule_tests.sh
From
Date
On 1/30/19 11:19 AM, Marcelo Henrique Cerri wrote:
> Fix the IPv4 address of the dummy0 interface and ensure that ip_forward
> is enabled in the network space to get a valid response when checking
> for routes between the gateway and other hosts.

you need a Fixes tag and to cc the author of said commit.

>
> Signed-off-by: Marcelo Henrique Cerri <marcelo.cerri@canonical.com>
> ---
> tools/testing/selftests/net/fib_rule_tests.sh | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/net/fib_rule_tests.sh b/tools/testing/selftests/net/fib_rule_tests.sh
> index d4cfb6a7a086..552a9784e759 100755
> --- a/tools/testing/selftests/net/fib_rule_tests.sh
> +++ b/tools/testing/selftests/net/fib_rule_tests.sh
> @@ -54,9 +54,11 @@ setup()
>
> $IP link add dummy0 type dummy
> $IP link set dev dummy0 up
> - $IP address add 198.51.100.1/24 dev dummy0
> + $IP address add 192.51.100.1/24 dev dummy0
> $IP -6 address add 2001:db8:1::1/64 dev dummy0
>
> + ip netns exec testns sysctl -w net.ipv4.ip_forward=1

ip_forward is not relevant for this test. It just adds routes and rules
and uses ip route get to verify; no traffic is actually genrated.

\
 
 \ /
  Last update: 2019-01-31 00:22    [W:0.041 / U:1.284 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site