lkml.org 
[lkml]   [2019]   [Jan]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] btrfs: relocation: fix unused variable
On Tue, Jan 29, 2019 at 02:01:46PM +0100, Anders Roxell wrote:
> When CONFIG_BRTFS_ASSERT isn't enabled, variable root_objectid isn't used.
>
> fs/btrfs/relocation.c: In function ‘insert_dirty_subv’:
> fs/btrfs/relocation.c:2138:6: warning: unused variable ‘root_objectid’ [-Wunused-variable]
> u64 root_objectid = root->root_key.objectid;
> ^~~~~~~~~~~~~
>
> Reworked by adding a runtime check in the assfail function instead of
> the '#ifdef CONFIG_BTRFS_ASSERT #else ...", so the compiler sees the
> condition being passed into an inline function after preprocessing.

I've fixed the warning by avoiding the local variable but I like your
fix in general, thanks.

\
 
 \ /
  Last update: 2019-01-29 16:23    [W:0.047 / U:12.728 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site