lkml.org 
[lkml]   [2019]   [Jan]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v2 3/9] irq/irq_sim: provide irq_sim_fire_type()
wt., 29 sty 2019 o 10:07 Uwe Kleine-König
<u.kleine-koenig@pengutronix.de> napisał(a):
>
> Hello Bartosz,
>
> On Tue, Jan 29, 2019 at 09:44:05AM +0100, Bartosz Golaszewski wrote:
> > -void irq_sim_fire(struct irq_sim *sim, unsigned int offset)
> > +void irq_sim_fire_type(struct irq_sim *sim,
> > + unsigned int offset, unsigned int type)
> > {
> > struct irq_sim_irq_ctx *ctx = irq_sim_get_ctx(sim, offset);
> >
> > - if (ctx->enabled) {
> > + /* Only care about relevant flags. */
> > + type &= IRQ_TYPE_SENSE_MASK;
> > +
> > + if (ctx->enabled && (ctx->type & type)) {
> > set_bit(offset, sim->work_ctx.pending);
> > irq_work_queue(&sim->work_ctx.work);
> > }
> > }
> > -EXPORT_SYMBOL_GPL(irq_sim_fire);
> > +EXPORT_SYMBOL_GPL(irq_sim_fire_type);
>
> This looks better than the previous variant. I wonder if it would be
> still more sensible to have type only in the mockup driver. But I don't
> have the complete picture here and it might be easier this way.
>

I'm afraid I don't follow. Wasn't that the way it was done in v1?

Bart

\
 
 \ /
  Last update: 2019-01-29 12:02    [W:0.084 / U:6.668 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site