lkml.org 
[lkml]   [2019]   [Jan]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] thermal: bcm2835: Fix crash in bcm2835_thermal_debugfs
From
Date
Hi Stefan,

On 29/01/2019 09:44, Stefan Wahren wrote:
> Hi Phil,
>
> Am 29.01.2019 um 10:10 schrieb Phil Elwell:
>> "cat /sys/kernel/debug/bcm2835_thermal/regset" causes a NULL pointer
>> dereference in bcm2835_thermal_debugfs. The driver makes use of the
>> implementation details of the thermal framework to retrieve a pointer
>> to its private data from a struct thermal_zone_device, and gets it
>> wrong - leading to the crash. Instead, store its private data as the
>> drvdata and retrieve the thermal_zone_device pointer from it.
>>
>> Fixes: bcb7dd9ef206 ("thermal: bcm2835: add thermal driver for bcm2835 SoC")
>>
>> Signed-off-by: Phil Elwell <phil@raspberrypi.org>
>
> thanks for this patch.
>
> Could you please resend this patch to the thermal maintainers Zhang Rui and Eduardo Valentin?||||
>
> Regards
> Stefan
>

I blame the get_maintainer script - a "Supporter" sounds less invested and less authoritative
than a "Maintainer".

A resend is imminent.

Phil

\
 
 \ /
  Last update: 2019-01-29 11:28    [W:0.064 / U:0.092 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site