lkml.org 
[lkml]   [2019]   [Jan]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v4 2/2] staging: erofs: complete POSIX ACL support
On Tue, Jan 29, 2019 at 04:35:20PM +0800, Gao Xiang wrote:
> Let's add .get_acl() to read the file's acl from its xattrs
> to make POSIX ACL usable.
>
> Here is the on-disk detail,
> fullname: system.posix_acl_access
> struct erofs_xattr_entry:
> .e_name_len = 0
> .e_name_index = EROFS_XATTR_INDEX_POSIX_ACL_ACCESS (2)
>
> fullname: system.posix_acl_default
> struct erofs_xattr_entry:
> .e_name_len = 0
> .e_name_index = EROFS_XATTR_INDEX_POSIX_ACL_DEFAULT (3)
>
> Reviewed-by: Chao Yu <yuchao0@huawei.com>
> Signed-off-by: Gao Xiang <gaoxiang25@huawei.com>
> ---
> change log v4:
> - leave kmalloc and wait the conclusion of fault injection
> pointed out by Dan Carpenter;

I do think this is the right thing, but I also wasn't going to ask you
do redo v3. Anyway, thanks!

regards,
dan carpenter

\
 
 \ /
  Last update: 2019-01-29 09:44    [W:0.041 / U:4.232 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site