lkml.org 
[lkml]   [2019]   [Jan]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 03/28] thunderbolt: Enable TMU access when accessing port space on legacy devices
On Tue, Jan 29, 2019 at 06:01:18PM +0300, Mika Westerberg wrote:
> + if (enable)
> + value |= BIT(20);

Can we have a macro for this bit?


> +int tb_port_find_cap(struct tb_port *port, enum tb_port_cap cap)
> +{
> + int ret;
> +
> + ret = tb_port_enable_tmu(port, true);
> + if (ret)
> + return ret;
> +
> + ret = __tb_port_find_cap(port, cap);
> +
> + tb_port_enable_tmu(port, false);
> +
> + return ret;
> +}

Would there be a downside to setting the TMU bit on all ports all the time
(e.g. on switch enumeration)?

Thanks,

Lukas

\
 
 \ /
  Last update: 2019-01-29 22:59    [W:0.171 / U:5.900 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site