lkml.org 
[lkml]   [2019]   [Jan]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
Subject[tip:irq/core] genirq/debugfs: No need to check return value of debugfs_create functions
Commit-ID:  434537bbd50fefc89c1e29170bf4030ae3ec445a
Gitweb: https://git.kernel.org/tip/434537bbd50fefc89c1e29170bf4030ae3ec445a
Author: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
AuthorDate: Tue, 22 Jan 2019 16:21:49 +0100
Committer: Thomas Gleixner <tglx@linutronix.de>
CommitDate: Tue, 29 Jan 2019 20:04:21 +0100

genirq/debugfs: No need to check return value of debugfs_create functions

When calling debugfs functions, there is no need to ever check the return
value. The function can work or not, but the code logic should never do
something different based on this.

Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Cc: Marc Zyngier <marc.zyngier@arm.com>
Link: https://lkml.kernel.org/r/20190122152151.16139-50-gregkh@linuxfoundation.org

---
kernel/irq/debugfs.c | 2 --
kernel/irq/irqdomain.c | 2 --
2 files changed, 4 deletions(-)

diff --git a/kernel/irq/debugfs.c b/kernel/irq/debugfs.c
index 6f636136cccc..bbd783a83409 100644
--- a/kernel/irq/debugfs.c
+++ b/kernel/irq/debugfs.c
@@ -256,8 +256,6 @@ static int __init irq_debugfs_init(void)
int irq;

root_dir = debugfs_create_dir("irq", NULL);
- if (!root_dir)
- return -ENOMEM;

irq_domain_debugfs_init(root_dir);

diff --git a/kernel/irq/irqdomain.c b/kernel/irq/irqdomain.c
index 8b0be4bd6565..45c74373c7a4 100644
--- a/kernel/irq/irqdomain.c
+++ b/kernel/irq/irqdomain.c
@@ -1749,8 +1749,6 @@ void __init irq_domain_debugfs_init(struct dentry *root)
struct irq_domain *d;

domain_dir = debugfs_create_dir("domains", root);
- if (!domain_dir)
- return;

debugfs_create_file("default", 0444, domain_dir, NULL,
&irq_domain_debug_fops);
\
 
 \ /
  Last update: 2019-01-29 20:08    [W:0.041 / U:10.524 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site