lkml.org 
[lkml]   [2019]   [Jan]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC][PATCH] Revert "ARM: dts: bcm2837: Fix polarity of wifi reset GPIOs"
Hi,

> Ioan-Adrian Ratiu <adi@adirat.com> hat am 28. Januar 2019 um 19:31 geschrieben:
>
>
> Hi Stefan and thank you for looking into this,
>
> On Sun, 27 Jan 2019, Stefan Wahren <stefan.wahren@i2se.com> wrote:
> > Hi Ioan-Adrian,
> >
> >> Ioan-Adrian Ratiu <adi@adirat.com> hat am 27. Januar 2019 um
> >> 21:28 geschrieben: This reverts commit
> >> bea8a160c621d19f7f78b13e14e03f4b8e44cd4b. Contrary to what
> >> the commit message says, on my rpi 3 b v1.2 changing the
> >> polarity causes the exact behaviour this commit intends to fix,
> >> as described at the referenced link below (wlan0 disapears).
> >> With reset-gpios = ... GPIO_ACTIVE_HIGH, brcmfmac errors in
> >> dmesg: [ 7.977512] brcmfmac: brcmf_sdio_bus_sleep: error
> >> while changing bus sleep state -110 [ 7.977623] brcmfmac:
> >> brcmf_sdio_txfail: sdio error, abort command and terminate
> >> frame [ 7.978007] brcmfmac: brcmf_sdio_txfail: sdio error,
> >> abort command and terminate frame [ 7.978377] brcmfmac:
> >> brcmf_sdio_txfail: sdio error, abort command and terminate
> >> frame [ 7.978724] brcmfmac: brcmf_sdio_dpc: failed backplane
> >> access over SDIO, halting operation [ 7.978734] brcmfmac:
> >> brcmf_proto_bcdc_query_dcmd: brcmf_proto_bcdc_msg failed
> >> w/status -110 [ 7.978747] brcmfmac:
> >> brcmf_cfg80211_get_channel: chanspec failed (-110) [
> >> 7.982817] brcmfmac: brcmf_sdio_bus_sleep: error while changing
> >> bus sleep state -110 [ 7.982880] brcmfmac:
> >> brcmf_sdio_txfail: sdio error, abort command and terminate
> >> frame [ 7.983255] brcmfmac: brcmf_sdio_txfail: sdio error,
> >> abort command and terminate frame The only solution I
> >> currently have is to revert and everything works as expected
> >> and as before changing the polarity. Link:
> >> https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=911443
> >> Signed-off-by: Ioan-Adrian Ratiu <adi@adirat.com> ---
> >
> > reverting this commit will only workaround the real issue. It
> > lies in the sdhci-iproc driver.
> >
> > Could please try this instead patch [1]?
>
> Yes, the patch fixes the bug and it's also in Linus' master branch
> in v5.0-rc3 as commit 2bd44da ("mmc: sdhci-iproc: handle
> mmc_of_parse() errors during prob").
>
> There was just a minor conflict cherry-picking it to 4.19.y
> (sdhci_get_property -> sdhci_get_of_property).
>
> I would really like to have 2bd44da backported to the 4.19 stable
> tree to have wifi working again. Please?
>
> Tested-by: Ioan-Adrian Ratiu <adi@adirat.com> #4.19.18

i wasn't aware of this conflict until sunday. Yes, i will backport it.

Thanks
Stefan

>
> >
> > [1] - https://patchwork.kernel.org/patch/10741809/

\
 
 \ /
  Last update: 2019-01-28 19:45    [W:0.055 / U:1.920 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site