lkml.org 
[lkml]   [2019]   [Jan]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 2/2] staging: erofs: complete POSIX ACL support
On Tue, Jan 29, 2019 at 12:41:55AM +0800, Chao Yu wrote:
> Hi Dan and Xiang,
>
> On 2019-1-28 21:48, Gao Xiang wrote:
> > Hi Dan,
> >
> > On 2019/1/28 21:33, Dan Carpenter wrote:
> >> Hopefully, regular kmalloc() is enough.
> >>
> >> Do really need the erofs_kmalloc() function? Regular kmalloc() has
> >> fault injection already. Have you tried to use it?
>
> Yes, I think we'd better to use erofs_kmalloc(). :)
>
> Actually, fault injection in erofs_kmalloc only affect erofs module, we can
> expect that the range of fault can be limited in erofs code, rather than whole
> kernel, so the test point can be aimed at more accurately.
>

Are you serious? The standard fault injection doesn't do that???

Please fix it instead of creating a duplicate better implementation
which only your filesystem can use. I would have thought that obviously
any fault injection framework could at least be configured to test
specific code...

regards,
dan carpenter

\
 
 \ /
  Last update: 2019-01-28 19:31    [W:0.160 / U:0.104 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site