lkml.org 
[lkml]   [2019]   [Jan]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 3/7] coresight: Use event attributes for sink selection
On Tue, Jan 15, 2019 at 04:07:38PM -0700, Mathieu Poirier wrote:
> + /* First get the selected sink from user space. */
> + sink = coresight_get_sink_by_id(event->attr.config2);

(I know there's a new version out, I'll go look there shortly)

should this patch not also have something like:

PMU_FORMAT_ATTR(sinkid, "config2:0-63");

> + if (!sink)
> + sink = coresight_get_enabled_sink(true);
> if (!sink || !sink_ops(sink)->alloc_buffer)
> goto err;

\
 
 \ /
  Last update: 2019-01-23 22:04    [W:0.182 / U:2.552 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site