lkml.org 
[lkml]   [2019]   [Jan]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 12/22] x86/fpu: Only write PKRU if it is different from current
From
Date
On 1/9/19 3:47 AM, Sebastian Andrzej Siewior wrote:
> +static inline void __write_pkru(u32 pkru)
> +{
> + /*
> + * Writting PKRU is expensive. Only write the PKRU value if it is
> + * different from the current one.
> + */

I'd say:

WRPKRU is relatively expensive compared to RDPKRU.
Avoid WRPKRU when it would not change the value.

In the grand scheme of things, WRPKRU is cheap. It's certainly not an
"expensive instruction" compared to things like WBINVD.

> + if (pkru == __read_pkru())
> + return;
> + __write_pkru_insn(pkru);
> +}

Is there a case where we need __write_pkru_insn() directly? Why not
just put the inline assembly in here?

\
 
 \ /
  Last update: 2019-01-23 19:10    [W:0.444 / U:2.844 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site