lkml.org 
[lkml]   [2019]   [Jan]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] Revert "staging:r8188eu: use lib80211 CCMP decrypt"
From
Date
On 1/2/19 4:06 AM, Larry Finger wrote:
> On 1/1/19 1:31 PM, Michael Straube wrote:
>>
>> I've tested your patch and it solved the issue. No freezes and dmesg
>> looks good.
>>
>> I noticed that try_then_request_module() is also used in
>> rtw_wep_encrypt() and
>> rtw_wep_decrypt(). I guess that also could cause problems?
>
> Yes, I believe it would if anyone is still using WEP. My plan is to get
> rid of the try_then_request_module() there as well, and for
> completeness, I plan to restore usage of the lib80211 routines for TKIP
> as well.

Patch "load lib80211 crypto ops from interruptible context" (
http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2018-August/124851.html
) is a preparation to replace
crypto_ops = try_then_request_module(lib80211_get_crypto_ops(*),
"lib80211_crypt_*");
with
(struct crypto_algorithm).ops

>
> Once I get a chance to test the TKIP and WEP changes, I plan to have a
> set of 4 patches to switch the driver to using lib80211 routines for all
> decryption/encryption.


There are four other patches to use lib80211:
use lib80211 CCMP decrypt (
http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2018-February/116533.html
)
Use lib80211 to encrypt (WEP) tx frames (
http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2018-June/122642.html
)
Use lib80211 to encrypt (TKIP) tx frames (
http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2018-July/123249.html
)
Use lib80211 to encrypt (CCMP) tx frames (
http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2018-July/123250.html
)

They all crash when try_then_request_module() called.

>
> Larry
>
>

\
 
 \ /
  Last update: 2019-01-02 20:34    [W:0.062 / U:0.780 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site