lkml.org 
[lkml]   [2019]   [Jan]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] n_tty: update comment for WAKEUP_CHARS define
From
Date
On 29. 12. 18, 13:48, Valentin Vidic wrote:
> Give a better descriptions of what WAKEUP_CHARS represents.
>
> Signed-off-by: Valentin Vidic <Valentin.Vidic@CARNet.hr>

I am not a native speaker, but this is much better than the current text.

Acked-by: Jiri Slaby <jslaby@suse.cz>

BTW this text is copy&pasted from/to all the other WAKEUP_CHARS
locations. Care to fix them all?

> ---
> drivers/tty/n_tty.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/tty/n_tty.c b/drivers/tty/n_tty.c
> index 3ad460219fd6..1dfbd45746da 100644
> --- a/drivers/tty/n_tty.c
> +++ b/drivers/tty/n_tty.c
> @@ -50,8 +50,10 @@
> #include <linux/ratelimit.h>
> #include <linux/vmalloc.h>
>
> -
> -/* number of characters left in xmit buffer before select has we have room */
> +/*
> + * Until this number of characters is queued in the xmit buffer, select will
> + * return "we have room for writes".
> + */
> #define WAKEUP_CHARS 256
>
> /*
>

thanks,
--
js
suse labs

\
 
 \ /
  Last update: 2019-01-02 07:49    [W:0.071 / U:9.656 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site