lkml.org 
[lkml]   [2019]   [Jan]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] Staging: vt6655: Fix camel case of variable
On Sat, Dec 29, 2018 at 11:59:52PM +0100, Petr Sedlák wrote:
> Replace variable uDelayUnit with u_delay_unit. Issue found by
> checkpatch.
>
> Signed-off-by: Petr Sedlák <hugosedlak@gmail.com>
> ---
> drivers/staging/vt6655/upc.h | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/vt6655/upc.h b/drivers/staging/vt6655/upc.h
> index 61b3e568ff9a..384af225336a 100644
> --- a/drivers/staging/vt6655/upc.h
> +++ b/drivers/staging/vt6655/upc.h
> @@ -42,15 +42,15 @@
> #define VNSvOutPortD(dwIOAddress, dwData) \
> iowrite32((u32)(dwData), dwIOAddress)
>
> -#define PCAvDelayByIO(uDelayUnit) \
> +#define PCAvDelayByIO(u_delay_unit) \
> do { \
> unsigned char byData; \
> unsigned long ii; \
> \
> - if (uDelayUnit <= 50) { \
> - udelay(uDelayUnit); \
> + if (u_delay_unit <= 50) { \
> + udelay(u_delay_unit); \
> } else { \
> - for (ii = 0; ii < (uDelayUnit); ii++) \
> + for (ii = 0; ii < (u_delay_unit); ii++) \
> byData = inb(0x61); \
> } \
> } while (0)


This is a hilariously awful macro. It reads from a register usec number
of times to introduce a delay. :P

Just delete it and fix the callers to use normal delay functions.

regards,
dan carpenter

\
 
 \ /
  Last update: 2019-01-02 12:08    [W:0.070 / U:0.568 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site