lkml.org 
[lkml]   [2019]   [Jan]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 6/8] mtd: rawnand: jz4780-bch: Don't set clock rate in driver
On Thu, 17 Jan 2019 22:06:32 -0300
Paul Cercueil <paul@crapouillou.net> wrote:

> This should be done in devicetree. Besides, it prevents us from
> supporting other SoCs which don't use the same clock frequency for the
> BCH hardware.

As I said earlier, I disagree with this statement, plus, you're
breaking backward compat with existing DTs when doing that.

>
> Signed-off-by: Paul Cercueil <paul@crapouillou.net>
> ---
> drivers/mtd/nand/raw/jz4780_bch.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/mtd/nand/raw/jz4780_bch.c b/drivers/mtd/nand/raw/jz4780_bch.c
> index 7e4e5e627603..161d3821e1c4 100644
> --- a/drivers/mtd/nand/raw/jz4780_bch.c
> +++ b/drivers/mtd/nand/raw/jz4780_bch.c
> @@ -57,8 +57,6 @@
> #define BCH_BHINT_UNCOR BIT(1)
> #define BCH_BHINT_ERR BIT(0)
>
> -#define BCH_CLK_RATE (200 * 1000 * 1000)
> -
> /* Timeout for BCH calculation/correction. */
> #define BCH_TIMEOUT_US 100000
>
> @@ -348,8 +346,6 @@ static int jz4780_bch_probe(struct platform_device *pdev)
> return PTR_ERR(bch->clk);
> }
>
> - clk_set_rate(bch->clk, BCH_CLK_RATE);
> -
> mutex_init(&bch->lock);
>
> bch->dev = dev;

\
 
 \ /
  Last update: 2019-01-18 09:32    [W:0.121 / U:4.044 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site