lkml.org 
[lkml]   [2019]   [Jan]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH v2 1/3] usb: ehci: fsl: Update register accessing for arm/arm64 platforms
Date
Hi Alan,

On January 18, 2019 00:08, Alan Stern wrote:
>
> On Thu, 17 Jan 2019, Ran Wang wrote:
>
> > arm/arm64's io.h doesn't define clrbits32() and clrsetbits_be32(),
> > which causing compile failure on some Layerscape Platforms (such as
> > LS1021A and LS2012A which also integrates FSL EHCI controller). So use
> > ioread32be()/iowrite32be() instead to make it workable on both powerpc
> > and arm.
>
> For patches 1/3 and 3/3:
>
> Acked-by: Alan Stern <stern@rowland.harvard.edu>
>
> Have you tested these on the Layerscape platforms to make sure they work
> correctly?

To be honest, the first goal of this patch set is to fix compile issue.
And I have verified it on LS1012AQDS, and encountered failure as below:

[ 2.966755] ehci-fsl: Freescale EHCI Host controller driver
[ 2.973113] fsl-ehci fsl-ehci.0: Freescale On-Chip EHCI Host Controller
[ 2.979851] fsl-ehci fsl-ehci.0: new USB bus registered, assigned bus number 3
[ 2.987549] fsl-ehci fsl-ehci.0: irq 22, io mem 0x08600000
[ 3.005769] fsl-ehci fsl-ehci.0: USB 2.0 started, EHCI 0.00
[ 3.012122] hub 3-0:1.0: USB hub found
[ 3.016088] hub 3-0:1.0: config failed, hub doesn't have any ports! (err -19)

However, actually the only board which I can find so far has known HW issue on
EHCI part, so I plan to find other platform to do complete verification when
possible. And will submit other fix if needed. Is that OK?

BTW, for powerpc platform, I've tested on a T1042AD4RDB and USB worked fine with it.

Regards,
Ran

\
 
 \ /
  Last update: 2019-01-18 03:40    [W:0.100 / U:0.460 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site