lkml.org 
[lkml]   [2019]   [Jan]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH] usb: chipidea: Grab the (legacy) USB PHY by phandle first
Date

> On Thu, 2019-01-17 at 06:44 +0000, Peter Chen wrote:
> >
> > > On Wed, 2019-01-16 at 14:44 +0100, Thomas Petazzoni wrote:
> > > > Well prior to your code, there was already a possibility for both
> > > > ci->phy and ci->usb_phy to be valid. I don't think it's really
> > > > ci->useful
> > > > to avoid the fallback when a generic PHY has already been found,
> > > > it's confusing. If really you want to clarify that, it should be:
> > > >
> > > > /* Let's first try to find a generic PHY */
> > > > ci->phy = devm_phy_get(dev->parent, "usb-phy");
> > > > if (IS_ERR(ci->phy)) {
> >
> > Please consider -EPROBE_DEFER case
> >
> > > > /* Fall back to legacy USB PHY */
> > > > ci->usb_phy = devm_usb_get_phy_by_phandle(dev->parent, "phys",
> > > 0);
> >
> > Please consider -EPROBE_DEFER case
> >
> > > > if (IS_ERR(ci->usb_phy))
> > > > ci->usb_phy = devm_usb_get_phy(dev->parent,
> > > USB_PHY_TYPE_USB2);
> > > > }
> > > >
> >
> > Below code
> > if (IS_ERR(ci->phy) && IS_ERR(ci->usb_phy)) {
> > ret = -EPROBE_DEFER;
> > goto ulpi_exit;
> > }
> >
> > needs to change as:
> >
> > if (PTR_ERR(ci->phy) ==-EPROBE_DEFER || PTR_ERR(ci->usb_phy)
> == -EPROBE_DEFER) {
> > ret = -EPROBE_DEFER;
> > goto ulpi_exit;
> > }
>
> Well I think this was more of a general outline than proper code to be included in
> the driver anyway :)
>
> I'm rather considering implementing what Thomas suggested at first, which is going
> for the fallback even if a generic PHY was found, as to stick more closely to the
> existing behavior.
>

Since one USB2 controller is impossible has two USB PHYs, if both PHYs (generic PHY
and USB PHY) are found, there must be error at code or dts. Besides, -EPROBE_DEFER
is not an real error, it means the PHY(USB-PHY) is existed, just not be ready.

Peter

> Cheers,
>
> Paul
>
> > Peter
> >
> > > > With that, you would only have either ci->phy or ci->usb_phy be
> > > > valid, and never both. With your change, you can have ci->phy and
> > > > ci->usb_phy both be valid if the legacy USB PHY was found using
> > > > devm_usb_get_phy_by_phandle(), but not if we fell back to
> > > > devm_usb_get_phy().
> > >
> > > Okay that makes sense, your suggestion is indeed more consistent
> > > with the existing behavior. I'll go with that in the next revision!
> > >
> >
> >
> --
> Paul Kocialkowski, Bootlin
> Embedded Linux and kernel engineering
> https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbootlin.com
> &data=02%7C01%7Cpeter.chen%40nxp.com%7C30302a1c0b414965af2608d
> 67c9a30f6%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C6368333990
> 21182420&sdata=lD7kt%2F%2FmUWp7FfLD9iMlxjfvS4ediv4uA%2BForbDSW
> kE%3D&reserved=0

\
 
 \ /
  Last update: 2019-01-18 03:19    [W:0.082 / U:5.956 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site