lkml.org 
[lkml]   [2019]   [Jan]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 0/3] tracing: probeevent: Fix probe argument parser and handler
On Thu, 17 Jan 2019 09:23:02 -0500
Steven Rostedt <rostedt@goodmis.org> wrote:

> On Thu, 17 Jan 2019 22:47:58 +0900
> Masami Hiramatsu <mhiramat@kernel.org> wrote:
>
> > Hi,
> >
> > This series fixes several bugs in probe event argument parser
> > and handler routines.
>
> Hi Masami,
>
> Can you resend with a "Fixes:" tag to each of the patches, so that it
> is easy to see what patch needs to be backported to which stable kernel
> (or not any stable release if the patch fixes something in 5.0-rc).

OK, I'll resend it with Fixed tags!
And maybe I also need to enhance ftracetest so that it can catch
this bug.

Thanks,

>
> Thanks!
>
> -- Steve
>
> >
> > Recently I got 2 issues reported by Andreas, see
> > https://www.mail-archive.com/linux-kernel@vger.kernel.org/msg1899098.html
> >
> > One issue is already fixed by Andreas (Thanks!) but $comm handling
> > issue still exists on uprobe event. [1/3] fixes it.
> > And I found other issues around that, [2/3] is just a trivial cleanup,
> > [3/3] fixes $comm type issue which occurs not only uprobe events but
> > also on kprobe events. Anyway, after this series applied, $comm must
> > be "string" type and not be an array.
> >
> > Thank you,
> >
> > ---
> >
> > Masami Hiramatsu (3):
> > tracing: uprobes: Re-enable $comm support for uprobe events
> > tracing: probeevent: Do not accumulate on ret variable
> > tracing: probeevent: Fix to make the type of $comm string
> >
> >
> > kernel/trace/trace_probe.c | 13 +++++++------
> > kernel/trace/trace_probe_tmpl.h | 2 +-
> > kernel/trace/trace_uprobe.c | 15 +++++++++++++--
> > 3 files changed, 21 insertions(+), 9 deletions(-)
> >
> > --
> > Masami Hiramatsu (Linaro) <mhiramat@kernel.org>
>


--
Masami Hiramatsu <mhiramat@kernel.org>

\
 
 \ /
  Last update: 2019-01-18 00:31    [W:0.059 / U:3.856 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site