lkml.org 
[lkml]   [2019]   [Jan]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3 0/4] Add NXP AUDMIX device and machine drivers
On Thu, Jan 17, 2019 at 02:22:18PM -0800, Nicolin Chen wrote:
> On Thu, Jan 17, 2019 at 12:46:25PM +0000, Viorel Suman wrote:
> > The patchset adds NXP Audio Mixer (AUDMIX) device and machine
> > drivers and related DT bindings documentation.
> >
> > Changes since V2:
> > 1. Moved "dais" node from machine driver DTS node to device driver DTS node
> > as suggested by Rob.
>
> Yea, it makes a lot of sense. Otherwise, since the connection
> between IP blocks is fixed inside the SoC, the virtual sound
> node would need to be put in the soc-level dtsi, which sounds
> odd to me.
>
> > Changes since V1:
> > 1. Original patch split into distinct patches for the device driver and
> > DT binding documentation.
> > 2. Replaced AMIX with AUDMIX in both code and file names as it looks more
> > RM-compliant.
> > 3. Removed polarity control from CPU DAI driver as suggested by Nicolin.
> > 4. Added machine driver and related DT binding documentation.
> >
> > Viorel Suman (4):
> > ASoC: fsl: Add Audio Mixer CPU DAI driver
> > ASoC: add fsl_audmix DT binding documentation
> > ASoC: fsl: Add Audio Mixer machine driver
> > ASoC: add imx-audmix DT binding documentation
>
> Reviewed-by: Nicolin Chen <nicoleotsuka@gmail.com>

Oops. Just saw Rob's new reply. The drivers look good to me though.

\
 
 \ /
  Last update: 2019-01-17 23:26    [W:0.110 / U:80.332 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site