lkml.org 
[lkml]   [2019]   [Jan]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [GIT PULL] timer fix
On Thu, 17 Jan 2019, Heiko Carstens wrote:
> On Thu, Jan 17, 2019 at 10:51:02AM +0100, Ingo Molnar wrote:
> >
> > * Heiko Carstens <heiko.carstens@de.ibm.com> wrote:
> >
> > > > - if (timr->it_requeue_pending == info->si_sys_private) {
> > > > + if (timr->it_interval && timr->it_requeue_pending == info->si_sys_private) {
> > > > timr->kclock->timer_rearm(timr);
> > >
> > > FWIW, with this patch the vanilla glibc 2.28 self tests
> > > rt/tst-cputimer1, rt/tst-cputimer2, and rt/tst-cputimer3
> > > start to fail on s390:
> ...
> > > I haven't looked any further into this, just reporting.. otherwise the
> > > test systems seem to be healthy.
> >
> > Could you please check whether the top commit in tip:timers/urgent fixes
> > it:
> > 93ad0fc088c5: posix-cpu-timers: Unbreak timer rearming
>
> Yes, the test cases don't fail anymore. Thanks!
>
> A general question: since I reported this already last year, was the
> bug report not usable? I understand that x-mas holidays were in
> between, just wondering if new "glibc test case" fails are worth to be
> reported like I did.

I was on a 3 weeks vacation and I tend to clean out my inbox when I return
as it turned out in the past that playing catch up is hopeless. The
important stuff comes back by itself :)

Thanks,

tglx

\
 
 \ /
  Last update: 2019-01-17 17:59    [W:0.045 / U:6.484 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site