[lkml]   [2019]   [Jan]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH 00/16] block: sed-opal: support shadow MBR done flag and write
On Thu, Jan 17, 2019 at 10:40:49AM +0100, David Kozub wrote:
> On Thu, 17 Jan 2019, Christoph Hellwig wrote:
> > the way the series appear looks odd, because it wasn't threaded or
> > even ordered, and the patches from Jonas seem to have been sent out
> > by you under his name. Can you resend them carefully threaded, all
> > mails from you with the additional from header for resends?
> Ouch. I'm sorry about the ordering/threading. I (wrongly) assumed that if I
> just send the mails in order, that suffices. I'll try to fix that in v2.
> W.r.t. "from": Most of the patches were originally created by Jonas. I
> touched some in order to apply review suggestions or make some small fixes.
> But some stayed identical to Jonas' version and I didn't want to strip him
> of authorship. I used git format-patch to produce the mails and the commit
> author was propagated to the from header.
> What is the proper way when I am not the author?

Send the actual mail as from you, and put another From: line for
the original author into the mail body as the first non-empty line.

 \ /
  Last update: 2019-01-17 16:22    [W:0.063 / U:1.112 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site