lkml.org 
[lkml]   [2019]   [Jan]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v2] tracing/uprobes: Fix output for multiple string arguments
From
Date
On 17. Jan 2019, at 15:51, Steven Rostedt <rostedt@goodmis.org> wrote:
>
> On Thu, 17 Jan 2019 15:29:09 +0100
> Andreas Ziegler <andreas.ziegler@fau.de> wrote:
>
>> From my side it's basically good to go, but I just realized that there
>> is no "Fixes: " tag in it but the problem it fixes goes back to
>> 5baaa59ef09e ("tracing/probes: Implement 'memory' fetch method for
>> uprobes") from 2013 (and is present in all current longterm and stable
>> kernels)... should I add a tag and resend a v3?
>>
>
> I was just about to ask you to provide the fixes tag. No need to
> resend, I'll just add it manually. I asked Masami to resend because it
> was a patch series. If it was just a single patch, I would have just
> asked what the fixes was for that particular patch. I can handle one
> patch, but not more than one ;-)
>
> -- Steve

One more thing maybe, the code in question was rewritten
by Masami in 9178412ddf5a ("tracing: probeevent: Return consumed
bytes of dynamic area”) which is in v4.20 but the problem traces back
to the original commit mentioned above, so it will need manual so we
will need a slightly modified version for earlier kernels.

Regards,

Andreas
\
 
 \ /
  Last update: 2019-01-17 16:15    [W:0.052 / U:9.804 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site