lkml.org 
[lkml]   [2019]   [Jan]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH net-next] virtio_net: bulk free tx skbs
On Wed, Jan 16, 2019 at 03:31:58PM -0800, David Miller wrote:
> From: "Michael S. Tsirkin" <mst@redhat.com>
> Date: Mon, 14 Jan 2019 20:34:26 -0500
>
> > Use napi_consume_skb() to get bulk free. Note that napi_consume_skb is
> > safe to call in a non-napi context as long as the napi_budget flag is
> > correct.
> >
> > Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> > ---
> >
> > My perf testing setup is down but it works fine on my devel box and
> > should be fairly uncontroversial.
>
> It would be uncontroversial if it compiled.
>
> drivers/net/virtio_net.c: In function ‘free_old_xmit_skbs’:
> drivers/net/virtio_net.c:1346:25: error: ‘use_napi’ undeclared (first use in this function); did you mean ‘used_math’?
> napi_consume_skb(skb, use_napi);
> ^~~~~~~~
> used_math
> drivers/net/virtio_net.c:1346:25: note: each undeclared identifier is reported only once for each function it appears in

Yes my bad it was on top of other patches.
I'm rebasing and will repost.

--
MST

\
 
 \ /
  Last update: 2019-01-17 14:36    [W:0.049 / U:5.284 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site