[lkml]   [2019]   [Jan]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH] watchdog: qcom: Add suspend/resume support
Hi Brian,

On 1/17/2019 3:01 PM, Brian Masney wrote:
> You can use the __maybe_unused attribute to remove the #ifdef:
> static int __maybe_unused qcom_wdt_suspend(struct device *dev)

Thanks for looking into this.

As for __maybe_unused, I think it's better to keep #ifdef rather than
this attribute which seems to be meaning unused when actually its
possible that it's used often(PM_SLEEP is def y). It's like saying
unused when you are actually using it. The attribute seems like a
hack to avoid compilation error. Please correct me if I am wrong.

- Sai
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation

 \ /
  Last update: 2019-01-17 11:40    [W:0.079 / U:1.176 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site