[lkml]   [2019]   [Jan]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH v2 2/2] leds: lp50xx: Add the LP50XX family of the RGB LED driver

> >>> You know what? First, submit driver with similar functionality to
> >>> existing RGB drivers, using same interface existing drivers are
> >>> using. When that is accepted, we can talk about extending
> >>> kernel<->user interfaces.
> >>>
> >>
> >> I could do that but then there is no way for users to have any other color but "white" with this driver.
> >> That defeats the purpose of the device itself.
> >
> > No, that is not what I meant.
> >
> > We do have RGB drivers in tree, they just present three separate LEDs
> > -- red, green and blue. I ask you to do the same for initial
> > submission.
> >
> For clarification you are asking me to register a LED class per
> output pin?


> As explained before the Master brightness register has absolute control over the output current
> to the LED outputs regardless of the color control setting.

Yes, just set master brightness to 255 and you can ignore it.

> > You'll still be able to set brightness independently on the
> > red/green/blue LEDs...
> >
> But which one would control the overall brightness of the cluster?

You would not have that control in initial version of the patch.

(cesky, pictures)
[unhandled content-type:application/pgp-signature]
 \ /
  Last update: 2019-01-17 11:07    [W:0.063 / U:0.564 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site