lkml.org 
[lkml]   [2019]   [Jan]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH] scsi: ufs: revamp string descriptor reading
Date
> > Hello Tomas,
> >
> > >
> > > Define new a type: uc_string_id for easier string handling and less
> > > casting. Reduce number or string copies in price of a dynamic
> > > allocation.
> > >
> > > Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
> > Tested-by: Avri Altman <avri.altman@wdc.com>
> >
> > Just one nit - doesn't really matters.
> >
> > Cheers,
> > Avri
> >
> > > ---
> > > drivers/scsi/ufs/ufs-sysfs.c | 20 ++---
> > > drivers/scsi/ufs/ufs.h | 2 +-
> > > drivers/scsi/ufs/ufshcd.c | 164 +++++++++++++++++++++--------------
> > > drivers/scsi/ufs/ufshcd.h | 9 +-
> > > 4 files changed, 115 insertions(+), 80 deletions(-)
> >
> >
> > >
> > > ufs_fixup_device_setup(hba, &card);
> > > + ufs_put_device_desc(&card);
> > ufs_get_device_desc() and ufs_put_device_desc() actually serves the
> > quirks setup.
> > Make sense to call it from within so the logic is clear and in one place.
> > Might also save ufs_put_device_desc().
>
> You are right from the current perspective , just I'd need it also for the RPMB
> patches that should follow, then it will have bit larger span than the quirks.
>

Is this okay, can we merge?
Thanks
Tomas

\
 
 \ /
  Last update: 2019-01-17 08:53    [W:0.079 / U:12.196 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site