lkml.org 
[lkml]   [2019]   [Jan]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 01/12] selftests: gpio-mockup-chardev: Check asprintf() for error
From
Date
On 1/14/19 6:51 AM, Geert Uytterhoeven wrote:
> With gcc 7.3.0:
>
> gpio-mockup-chardev.c: In function ‘get_debugfs’:
> gpio-mockup-chardev.c:62:3: warning: ignoring return value of ‘asprintf’, declared with attribute warn_unused_result [-Wunused-result]
> asprintf(path, "%s/gpio", mnt_fs_get_target(fs));
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>
> Handle asprintf() failures to fix this.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> tools/testing/selftests/gpio/gpio-mockup-chardev.c | 9 ++++++---
> 1 file changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/tools/testing/selftests/gpio/gpio-mockup-chardev.c b/tools/testing/selftests/gpio/gpio-mockup-chardev.c
> index f8d468f54e986dd0..aaa1e9f083c37215 100644
> --- a/tools/testing/selftests/gpio/gpio-mockup-chardev.c
> +++ b/tools/testing/selftests/gpio/gpio-mockup-chardev.c
> @@ -37,7 +37,7 @@ static int get_debugfs(char **path)
> struct libmnt_table *tb;
> struct libmnt_iter *itr = NULL;
> struct libmnt_fs *fs;
> - int found = 0;
> + int found = 0, ret;
>
> cxt = mnt_new_context();
> if (!cxt)
> @@ -58,8 +58,11 @@ static int get_debugfs(char **path)
> break;
> }
> }
> - if (found)
> - asprintf(path, "%s/gpio", mnt_fs_get_target(fs));
> + if (found) {
> + ret = asprintf(path, "%s/gpio", mnt_fs_get_target(fs));
> + if (ret < 0)
> + err(EXIT_FAILURE, "failed to format string");
> + }
>
> mnt_free_iter(itr);
> mnt_free_context(cxt);
>

Thanks for the patch. Applied to linux-kselftest fixes for 5.0-rc4

thanks,
-- Shuah

\
 
 \ /
  Last update: 2019-01-16 23:04    [W:0.123 / U:16.588 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site